Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ORCA asynchronous sampling #2205

Merged
merged 30 commits into from
Oct 8, 2024
Merged

ORCA asynchronous sampling #2205

merged 30 commits into from
Oct 8, 2024

Conversation

Omar-ORCA
Copy link
Contributor

Description

Support for asynchronous sampling for ORCA backend

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 11, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@khalatepradnya
Copy link
Collaborator

khalatepradnya commented Sep 16, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@sacpis sacpis self-requested a review September 16, 2024 18:20
sacpis
sacpis reviewed Sep 16, 2024
View reviewed changes
runtime/common/Executor.h Outdated Show resolved Hide resolved
sacpis
sacpis reviewed Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@sacpis sacpis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just have few comments.

@sacpis
Copy link
Collaborator

sacpis commented Sep 16, 2024

To fix Basic content checks CI job, please run these commands locally to see the issue on your local machine

bash scripts/run_clang_format.sh
bash scripts/run_all_spelling.sh

@khalatepradnya
* Code formatting
e83928b 
* Spell check
@khalatepradnya
Copy link
Collaborator

khalatepradnya commented Sep 16, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@khalatepradnya
Copy link
Collaborator

khalatepradnya commented Sep 18, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@khalatepradnya
Copy link
Collaborator

To fix Basic content checks CI job, please run these commands locally to see the issue on your local machine

bash scripts/run_clang_format.sh
bash scripts/run_all_spelling.sh

Fixed.

@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 18, 2024
@cuda-quantum-bot
Docs preview for PR #2205.
fc7aa8f
@khalatepradnya
Copy link
Collaborator

khalatepradnya commented Oct 2, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

github-actions bot pushed a commit that referenced this pull request Oct 2, 2024
@cuda-quantum-bot
Docs preview for PR #2205.
aef81ce
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

@khalatepradnya
Merge branch 'main' into async_sampling
a385d6c
@khalatepradnya
* Addressing review comment
9b979f2 
 -- refactored to remove orca-specific dependency at common level (i.e.
`Executor` and `ServerHelper` classes)
@khalatepradnya khalatepradnya added ecosystem enhancement New feature or request labels Oct 4, 2024
@khalatepradnya
Copy link
Collaborator

khalatepradnya commented Oct 4, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Oct 4, 2024
@cuda-quantum-bot
Docs preview for PR #2205.
c31880d
@khalatepradnya
Copy link
Collaborator

khalatepradnya commented Oct 7, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Oct 7, 2024
@cuda-quantum-bot
Docs preview for PR #2205.
b402497
1tnguyen
1tnguyen approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@1tnguyen 1tnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks @Omar-ORCA and @khalatepradnya!

@khalatepradnya
Copy link
Collaborator

khalatepradnya commented Oct 7, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@khalatepradnya khalatepradnya enabled auto-merge (squash) October 7, 2024 20:42
github-actions bot pushed a commit that referenced this pull request Oct 7, 2024
@cuda-quantum-bot
Docs preview for PR #2205.
3cee0e7
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

@khalatepradnya
Copy link
Collaborator

khalatepradnya commented Oct 7, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Oct 8, 2024
@cuda-quantum-bot
Docs preview for PR #2205.
2841dc1
@khalatepradnya khalatepradnya merged commit 77a4d82 into NVIDIA:main Oct 8, 2024
130 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@khalatepradnya khalatepradnya khalatepradnya left review comments

@sacpis sacpis sacpis left review comments

@1tnguyen 1tnguyen 1tnguyen approved these changes

@amccaskey amccaskey Awaiting requested review from amccaskey

Assignees
No one assigned
Labels
ecosystem enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Omar-ORCA @khalatepradnya @sacpis @1tnguyen